search

plone / plone.batching

Batching facilities for Plone
https://pypi.org/project/plone.batching
2 stars 8 forks source link

Config with default template #33

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

@mauritsvanrees @jensens @ericof

I would say this is ready for review and merge.

The changes here come from https://github.com/plone/meta/pull/1 (which has been rebased and refactored 😄 )

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

Oh right, check-manifest has been a bit of an eyesore as of late to me, so we might better integrate it. zest.releaser pre-release command already runs all the nice things right? like pyroma and others, right? we might as well add it on the linting part, to ensure that whenever we are about to make a release, all PRs have left the repository in a releaseable state 😄

mauritsvanrees commented 1 year ago

Mostly check-manifest and pyroma yes.

We can't call prerelease itself, if that is what you want, because it will want to make a commit. We could add some support perhaps.

There is also python -m -r -s. Needs docutils for full support.