search

plone / plone.batching

Batching facilities for Plone
https://pypi.org/project/plone.batching
2 stars 8 forks source link

Configuring with plone/meta #52

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Testing https://github.com/plone/meta/pull/95

With the current configuration from the ⬆️ PR one does not depend on a Plone GitHub organization admin to set up a workflow to get them to run 🎉

@ericof @mauritsvanrees @jensens @ale-rt This allows any developer on Plone, or Collective, GitHub organizations to start using the meta configuration on any repository and start benefiting from a greater Developer Experience 🤩 ✨ 💖

The minor drawback is that if we want to want 100% self-service, we also have to drop pre-commit.ci (⚠️ note .ci not pre-commit ) with its nice auto-update of versions and autofixes via comments...

Speaking for myself I would not mind losing both, as autofixes should be applied on the commits themselves rather than as separate commits (IMHO) and auto-updates is nice, and indeed updating all repositories is tedious, but on meta we can handle at least the plone repositories in a semi-automated way.

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!