add support for find-links

iham commented 4 years ago

having to build my own docker image just for some "private" addons seams dull to me, as most of the features (eg ADDONS) are already there.

as i run my own pypi server, i'd like to add find-links to the envs and be good.

as an env-var FIND_LINKS="..." might be suitable.

in the docker-initialize.py lets add

        find_links = self.env.get("PLONE_FIND_LINKS",
               self.env.get("FIND_LINKS", "")).strip().split()
       # empty find-links might render no find-links at all so lets do the complete string here
       if find_links:
               find_links = 'find-links += {find_links}'.format(find_links="\n\t".join(find_links))

to the def buildout section

adding {find_links} after [buildout] to the BUILDOUT_TEMPLATE and add the the find_links to the BUILDOUT_TEMPLATE.format() should do the trick.

pnicolli commented 3 years ago

I just noticed this issue. See #144

pnicolli commented 3 years ago

@avoinea I think this can be closed with the recently merged PR linked above, right?

iham commented 3 years ago

seems to be added - nice! thanks for pointing out @pnicolli

plone / plone.docker

add support for find-links #130