search

plone / plone.formwidget.autocomplete

z3c.form widget for Plone using jQuery Autocomplete
https://pypi.org/project/plone.formwidget.autocomplete
2 stars 12 forks source link

Fixed wrong javascript id in jsregistry #1

Closed jperals closed 10 years ago

jperals commented 11 years ago

Hi, I fixed a line which seems to be wrong and preventing Plone from finding the file formwidget-autocomplete.js.

Cheers

[Edit: removed "And I think there's still something wrong with multiselect widgets in this branch, but still don't know what exactly is wrong." Nothing is wrong with that, it was me :-) ]

jperals commented 11 years ago

Not 100% sure if you'll be interested in commit a76b995, which is just a merge of tag 1.2.3 that was actually added after creating this pull request. In any case, the important bugfix is ad9c24e.

jensens commented 10 years ago

looks like a forgotten or obsolete pull request. can we close it or is this still valid?

jperals commented 10 years ago

More forgotten than obsolete, I would say. Note that this issue is for the jQuery-UI branch. The commit ad9c24e alone should actually fix it. Unfortunately I don't have the time to continute testing this, though...

jensens commented 10 years ago

I dont know who is using the branch. If nobody else has interest I'll just close this one in one week.

jensens commented 10 years ago

Since nobody want to work on this one I close this request. If there is interest in working on this one in order to get it merged please feel free to reopen it.