plone / plone.formwidget.autocomplete

z3c.form widget for Plone using jQuery Autocomplete
https://pypi.org/project/plone.formwidget.autocomplete
2 stars 12 forks source link

Use plone i18n domain #17

Closed staeff closed 8 years ago

staeff commented 8 years ago

See https://github.com/plone/Products.CMFPlone/issues/983

mauritsvanrees commented 8 years ago

@vincentfretin Plone 4.3 still uses the master branch of this package. But 4.3 uses the 4.3.x branch of plone.app.locales, which will not have the translations for this package. So I think this means we have to create a 4.3 compatible branch of plone.formwidget.autocomplete from before this merge and increase the version of master. Do you agree?

I can do this easily. Just checking if I am misjudging anything.

vincentfretin commented 8 years ago

Maybe we should include the messages in plone.app.locales 4.3.x as well, to avoid maintaining branch for plone.formwidget.autocomplete just for translations, and maybe other packages @staeff worked on recently.

vincentfretin commented 8 years ago

Follow up on https://github.com/plone/Products.CMFPlone/issues/983#issuecomment-181845631

mauritsvanrees commented 8 years ago

I have released version 1.2.9 with this, for 4.3 and 5.0. Thanks!