search

plone / plone.formwidget.querystring

z3c.form-based widget for composing a Query string/search
https://pypi.org/project/plone.formwidget.querystring/
3 stars 4 forks source link

Fix way to decode utf8 into template #12

Closed bsuttor closed 8 years ago

bsuttor commented 8 years ago

Because I had some error :

UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 22: ordinal not in range(128)

And it's always better to use "safe_unicode" than .decode('utf8')

mauritsvanrees commented 8 years ago

Thanks for the fix, looks good to me. We do want to run the tests on Jenkins first, against all relevant Plone versions. I have started jobs for this. It is easy (I think) to do this yourself, so that is a little tip for the next time. Instructions on how to do this, are here: http://jenkinsploneorg.readthedocs.io/en/latest/run-pull-request-jobs.html

bsuttor commented 8 years ago

Thanks you for the tip, I will create the jenkins job next time ;)