Translate "Remove line"

plone / plone.formwidget.querystring

z3c.form-based widget for composing a Query string/search

https://pypi.org/project/plone.formwidget.querystring/

3 stars 4 forks source link

Translate "Remove line" #17

Closed hanirok closed 7 years ago

hanirok commented 7 years ago

i18n:attributes="value" instead of i18n:translate="removeline" to fully translate the template

vincentfretin commented 7 years ago

I'm ok to merge this, but we need a changelog entry. Do we need @hanirok to have signed the contributor agreement for this patch?

gforcada commented 7 years ago

@vincentfretin usually this is handled by @esteele (cases where to merge code that has no CA signed). I would say that as I hope to get more patches from @hanirok (thanks for this first one!) signing the CA should be a minimal one-time effort only...

gforcada commented 7 years ago

Now I see that @hanirok has already singed it! Great, thanks for doing that and keep patches coming! 😄