search

plone / plone.formwidget.querystring

z3c.form-based widget for composing a Query string/search
https://pypi.org/project/plone.formwidget.querystring/
3 stars 4 forks source link

Two bug fixes #2

Closed bosim closed 11 years ago

bosim commented 11 years ago

I believe i have fixed two bugs:

malthe commented 11 years ago

I believe this is correct. The 1.x branch uses the plone domain consistently, and as do packages such as plone.app.layout.

davisagli commented 11 years ago

Hmm, can you bind the window click event only while the widget is open, so that there's no overhead for processing the click otherwise?

bosim commented 11 years ago

@davisagli Fixed, and changelog entry added.

davisagli commented 11 years ago

Looks like you forgot to remove the line that binds the click when the page loads?

bosim commented 11 years ago

Hmm.. in fact i did this, because the widget was expanded on load.. but i'll try to fix that...

bosim commented 11 years ago

@davisagli updated

davisagli commented 11 years ago

Just tested this. Once I close the multiselection widget there's no indication of what values are selected, nor do I see a way to reopen the widget.

bosim commented 11 years ago

@davisagli Which browser?

bosim commented 11 years ago

sorry, i accidentially hit the merge button on this one :( anyway @davisagli davis please confirm which browser that fails, and i'll fix it.

davisagli commented 11 years ago

That happens for me in both Firefox and Chrome.