Remove backward compatibility for Products.PlacelessTranslationService

plone / plone.i18n

Text normalization logic and language, country, cctld data.

8 stars 11 forks source link

Remove backward compatibility for Products.PlacelessTranslationService #20

Closed ksuess closed 6 years ago

ksuess commented 6 years ago

Last thing used from PTS was an adapter for IUserPreferredLanguages. It is replaced in zope.publisher. Related pull requests: plone/Products.CMFPlone#2278 and https://github.com/plone/plone.app.testing/pull/44

mauritsvanrees commented 6 years ago

Jenkins 5.2 gives an error, and it has to do with translations. There is a small chance that this is coincidence, so let me start it again. I have just merged https://github.com/plone/Products.CMFPlone/pull/2278 and will restart the PR job now. Maybe some changes are needed in tests of Products.CMFPlone and plone.app.users.

mauritsvanrees commented 6 years ago

After rerunning, Jenkins still has two failures in these tests:

Products.CMFPlone.tests.test_robot.RobotTestCase.Scenario Set Site Language in the Language Control Panel
plone.app.users.tests.test_pam.TestUserDataPanelWithPAM.test_pam Can you have a look?

mauritsvanrees commented 6 years ago

Now that #22 and related PRs have been merged, I think this can be closed.