plone / plone.i18n

Text normalization logic and language, country, cctld data.
8 stars 11 forks source link

Support Cyrillic and Latin character sets for Serbian. [4.x] #37

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 3 years ago

This is for branch 4.x (Plone 5.2). I will make a PR for master as well.

See https://github.com/collective/plone.app.locales/issues/326

Let 'sr' be general Serbian. Can be Latin or Cyrillic. You can influence which character set is used, by choosing one of three values in an environment variable:

zope_i18n_allowed_languages sr
zope_i18n_allowed_languages sr@Cyrl
zope_i18n_allowed_languages sr@Latn

Default character set in Plone 5.2 is Cyrillic, but this may change to Latin in 6.0.

mister-roboto commented 3 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 3 years ago

Testing these together on Jenkins 5.2:

https://github.com/plone/plone.i18n/pull/37
https://github.com/collective/plone.app.locales/pull/327