search

plone / plone.i18n

Text normalization logic and language, country, cctld data.
8 stars 11 forks source link

Added native names for German and Dutch language variants #44

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Then all related language variants are shown together in the language control panel. Fixes https://github.com/plone/Products.CMFPlone/issues/824, at least for these two languages.

BTW, it can be tricky to decide how to call this. For nl-be (Dutch spoken in Belgium) I called it "Nederlands (België)", which is the format that we use for most native languages in this dictionary. Native speakers would really call it "Vlaams" (Flemish). But then it would not be shown together with the other Dutch variants, so I suppose the way I have it now is good.

@agitator Please check my German spelling. :-)

mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs