Button UI

[Vansh-Baghel]

UI issue Button UI is really not good for a professional website.

Solution Increase the padding and font-size to 1 rem in all buttons.

Additional context

From this :

To this :

[fredvd]

@Vansh-Baghel thank you for the PR. I will look at it technically tomorrow morning when the Alpine City Sprint starts. Travel day now.

One question in advance. I see you changed the button background to white. This looks good on a dark background, but the card can have any image (svg or bitmap/photo background). On such sometimes lighter backgrounds the button could become much less visible.

The styling (color and extra border) are also there for a reason, it needs to be a compromise for all kinds of backgrounds.

I’ve heard there’s some css in development to check for contrasts, but that’s not generally available yet in browsers 😬

[Vansh-Baghel]

@Vansh-Baghel thank you for the PR. I will look at it technically tomorrow morning when the Alpine City Sprint starts. Travel day now.

One question in advance. I see you changed the button background to white. This looks good on a dark background, but the card can have any image (svg or bitmap/photo background). On such sometimes lighter backgrounds the button could become much less visible.

The styling (color and extra border) are also there for a reason, it needs to be a compromise for all kinds of backgrounds.

I’ve heard there’s some css in development to check for contrasts, but that’s not generally available yet in browsers 😬

I have hovered on the button, thats why its color seemed to be changed. I didn't change the color, its the same dark background.

[PriyanshuRj]

Is this issue still open for contribution ?

[fredvd]

better implementation in 95