Image caption support in Plone 5

plone / plone.outputfilters

Provides a framework for registering filters that get applied to text as it is rendered.

6 stars 15 forks source link

Image caption support in Plone 5 #36

Closed thet closed 4 years ago

thet commented 5 years ago

Change the image caption template to use <figure> and <figcaption>.
Add an ImageCaptioningEnabler utility which can be enabled via the portal registry setting plone.image_captioning.

Merge: https://github.com/plone/mockup/pull/911 https://github.com/plone/plone.staticresources/pull/30 https://github.com/plone/Products.CMFPlone/pull/2887 https://github.com/plone/plone.outputfilters/pull/36 https://github.com/plone/plone.app.upgrade/pull/226

mister-roboto commented 5 years ago

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

thet commented 5 years ago

Reminder to self, TODO: Check what happens, when mockup sets cations. Outputfilter should not. See css class captioned

davilima6 commented 4 years ago

@jenkins-plone-org please run jobs