Closed Rudd-O closed 2 years ago
@Rudd-O thanks for creating this Pull Request and help improve Plone!
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.
Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
@jenkins-plone-org please run jobs
With this simple comment all the jobs will be started automatically.
Happy hacking!
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
The test failures remaining above are caused by dependencies of the test framework and are also in evidence here: https://github.com/plone/plone.app.linkintegrity/pull/84
They need to be fixed. The code is otherwise correct.
@jensens PTAL thanks :-)
@jensens can this be reviewed again please? Yet another alpha went without this.
Tests running. Will babysit; if they pass, please stamp approval so I can merge.
@jenkins-plone-org please run jobs
@jensens I believe your change requests have been addressed. The regressions appear unrelated.
Merging now.
This change ensures that URLs are not output as
resolveuid/...
when served to the user. This does not particularly affect link integrity when browsing normally, but without this, content in RSS feeds cannot display videos or play audio files.Related: