plone / plone.outputfilters

Provides a framework for registering filters that get applied to text as it is rendered.
6 stars 15 forks source link

uuidToObject needs to take language into account #51

Closed erral closed 2 years ago

erral commented 2 years ago

When using plone.app.multilingual in a site, images and files added to the assets folder are shown automatically in all languages thanks to the LIF.

But those images share the UID across languages.

So if you add an image to the assets folder in English, you go to the Spanish part of the site, and reference that image from the media folder (spanish counterpart of the assets folder), the generated URL is /en/assets/file instead of /es/media/file. This is because uuidToObject and uuidToUrl look for the relevant UID and return the first found object.

I think that language should be taken into account in the catalog search to return the corresponding item.

cc: @libargutxi @ionlizarazu

mauritsvanrees commented 2 years ago

We should be using the version from plone.app.uuid instead of our own one. See https://github.com/plone/plone.outputfilters/issues/52 that I just created.

I will close this issue and copy the text to the plone.app.uuid issue you created.