search

plone / plone.patternslib

An add-on to make patternslib patterns available within Plone 5.
https://pypi.org/project/plone.patternslib/
GNU General Public License v2.0
2 stars 5 forks source link

Release? #16

Closed jensens closed 7 years ago

jensens commented 7 years ago

May we have a release? The latest on PyPI is kind of broken in a current Plone 5.

agitator commented 7 years ago

should https://github.com/plone/plone.patternslib/pull/12 be merged then?

jensens commented 7 years ago

@agitator it think if the missing changelog entry is added it can be merged.

pilz commented 7 years ago

@jensens I am completely swamped, but I gave you rights on pypi, feel free to push a release.

jensens commented 7 years ago

@pilz thanks!

@thet is #12 ok for merge? I am a bit lost with the details.

thet commented 7 years ago

@jensens , branch #12 is working quite well and proved in production. the only thing which I'm uneasy with merging #12 is, that it uses an unmerged branch of Patternslib - this is the PR: https://github.com/Patternslib/Patterns/pull/480 this PR is failing for a unknown reason, which does not seem related to my changes...

thet commented 7 years ago

oh-oh I just re-triggered a travis rebuild of Patternslib/Patterns#480 and it's passing! without any changes, I love it.

thet commented 7 years ago

@jensens i'd wait for the merge of Patternslib/Patterns#480 - if it will be merged. than the patternslib installation of plone.patternslib should be updated, IMO.

thet commented 7 years ago

@jensens @agitator plone.patternslib is now ready to be released. I've merged my branch (has massive changes due to a general resource update).

jensens commented 7 years ago

Release as 1.0 done!