plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Config with default template #100

Closed jensens closed 1 year ago

jensens commented 1 year ago
mister-roboto commented 1 year ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

@jensens did you branch it for 5.2 and updated sources.cfg in buildout.coredev ?

According to mr.roboto you haven't 😄

jensens commented 1 year ago

@gforcada I did while you wrote the lines above.

jensens commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

If you want to remove the python 2.7 jenkins jobs' checks you can add a commit, or reorder the commits (with a git rebase -i ✨ ) 😄

jensens commented 1 year ago

@jenkins-plone-org please run jobs