plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Add forward compatibility for auto protection in the 2.x branch #40

Closed mauritsvanrees closed 8 years ago

mauritsvanrees commented 8 years ago

I thought I had created a pull request already, but I was wrong. This is needed for https://github.com/plone/buildout.coredev/pull/176 and is tested there. Plone 4.3 only.

This does not add auto csrf protection. But it makes it easier to write code that works with both 2.x and 3.x. Put simply, it makes sure that trying to disable auto csrf protection on 2.x (which does not have it) does not fail.

mauritsvanrees commented 8 years ago

@vangheem Do you see problems with this pull request, or the full pull request at https://github.com/plone/buildout.coredev/pull/176 ?

vangheem commented 8 years ago

@mauritsvanrees this looks fine to me!