plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

CSRF Protection - improved log when transaction is aborted #43

Closed rristow closed 8 years ago

rristow commented 8 years ago

More information in the logs will be useful if the transaction is aborted.

vangheem commented 8 years ago

Thank you. Maybe we should use the exc_info=True switch instead of the traceback module?

rristow commented 8 years ago

In this case there is no exception throwed, this reason there is no information in the "exc_info".

mauritsvanrees commented 8 years ago

Can you squash the commits into one for clarity? There are now five commits that in the end only change two lines. If you are not comfortable with squashing, you can also create a new branch and do it there.

Also, as the automatic mister-roboto comment says: you (or actually @fhnwba who did the commits) should sign the Plone Contributor Agreement.