search

plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Avoid regenerating image scale over and over in Plone 4. #48

Closed mauritsvanrees closed 8 years ago

mauritsvanrees commented 8 years ago

Avoid (unnoticed) error when refreshing lock in Plone 4, plus a few other cases that were handled by plone4.csrffixes. Fixes https://github.com/plone/plone.protect/issues/47

mauritsvanrees commented 8 years ago

Okay, the 4.3 tests fail, but that is because they fail with plone4.csrffixes too. Or rather: it fails with plone.protect 3.x. This is why we officially keep plone.protect 2.x in Plone 4.

mauritsvanrees commented 8 years ago

Can anyone have a look at this? As said, Jenkins on Plone 4.3 can't possibly pass, because various tests can't handle plone.protect version 3. So this failing check can be ignored.

cekk commented 8 years ago

Any news about this PR? I have a similar behavior with a custom template that renders a list of scaled images for a collection. I don't have Maurits's problem because when a scale isn't generated (a new item appears in the collection), i see the "confirm button page" of plone.protect and after confirm, the scale is properly generated. But this isn't less annoying,