search

plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Report the actual URL not in portal #66

Closed gforcada closed 6 years ago

gforcada commented 7 years ago

Today I got this traceback from our servers:

1501692148.280.699304745381 https://DOMAIN.de/@@confirm-action
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.PloneHotfix20160830.confirm, line 10, in ConfirmView__call__
Forbidden: url not in portal

Note: we are using Plone 5.0.6, so the code here on PloneHotfix is already folded into plone.protect since version 3.0.20 (thanks @mauritsvanrees!)

So while seeing that traceback I got curious on which URL could that be? It would be nice if plone.protect could show that as well as part of the traceback.

mauritsvanrees commented 7 years ago

I guess it is fine to log the forbidden url here.

@vangheem Do you have an objection to that?

vangheem commented 7 years ago

Yup, that'd be fine.

frisi commented 6 years ago

fixed by #67