search

plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Fix package dependencies #80

Closed hvelarde closed 6 years ago

hvelarde commented 6 years ago

cssselect has been an extra of lxml since 2014.

https://github.com/lxml/lxml/commit/f601d017a344b337c071c9ebbcb9684e52055d59

refs, #79

hvelarde commented 6 years ago

@plone/framework-team please review!

jensens commented 6 years ago

Good catch, just merge.

hvelarde commented 6 years ago

thank you!

@plone/release-team can we have a 3.0.27 release of this package?

mauritsvanrees commented 6 years ago

I have released 4.0.0 with this fix. Errrr.... no, I haven't. I thought I had pulled master, but that was in a different checkout. So 4.0.0 does not have your fix... Try 4.0.1. :-) Sorry for the mixup.

BTW, I am not sure, but this might need backporting to the 3.x branch (Plone 5.1 and lower).

hvelarde commented 6 years ago

@mauritsvanrees this pull request was aimed to 3.0.x branch; the one we are using with Plone 4.3.

can we have a 3.0.27 release of this package?

mauritsvanrees commented 6 years ago

Ah, not my clearest day apparently... Okay, I have released 3.0.27.