search

plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

Add missing z3c.zcmlhook dependency #96

Closed icemac closed 1 year ago

icemac commented 1 year ago

configure.zcml uses this dependency to load its meta.zcml.

mister-roboto commented 1 year ago

@icemac thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 1 year ago

Well, let's run the tests first. There should be no problem, but unexpected side effects happen.

@jenkins-plone-org please run jobs