search

plone / plone.protect

HTTP protection utilities for the Plone CMS
https://pypi.org/project/plone.protect/
7 stars 8 forks source link

do not depend here on plone.portlets #99

Closed jensens closed 1 year ago

jensens commented 1 year ago

prepare for a world without portlets.

mister-roboto commented 1 year ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

@jensens It looks like you created a 4.x branch after merging this PR, and let coredev 5.2 use it. We don't want this code on Plone 5.2 I think. Is it okay if I revert the change on the 4.x branch? Or you can do it.

jensens commented 1 year ago

Ops. I'll branch away from prior my commit, ok?

mauritsvanrees commented 1 year ago

Yes, that should be fine too.

mauritsvanrees commented 1 year ago

Well, I decided to revert the commit in 68ba6848cf06010fe9fc36147084ddaac185383f. Less nice git history, but better for people who have meanwhile gotten the 4.x branch.