search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 5 forks source link

Integrate isort #148

Closed gforcada closed 9 years ago

gforcada commented 9 years ago

Finally my pull request on isort got merged and released (4.1.0).

Which basically means that upon integrating isort on p.r.codeanalysis we can drop our own import checker and use isort for it, which on top of that, not only sorts the way plone.api describes but can do both reporting only (for CI and commit hook integration) as well as automatically fixing all imports.

I will try to do it, but please beat me on that!

tisto commented 9 years ago

AWESOME!!! Can't wait to see that in p.r.codeanalysis! :)

saily commented 9 years ago

I'll check this and already put it on my todo list, great!

saily commented 9 years ago

@tisto @gforcada do you prefer to have an isort.cfg file or using the same approach we use for flake8-option. I would suggest we support both, but which should be default?

gforcada commented 9 years ago

@saily isort itself already checks for isort.cfg I guess... but concerning p.r.codeanalysis, I would ignore it completely, let's keep everything on a buildout part definition.