search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 5 forks source link

Add flake8-isort. #157

Closed tisto closed 9 years ago

tisto commented 9 years ago

@gforcada code-analysis fails after adding flake8-isort on my machine:

ImportError: 'module' object has no attribute 'Flake8IsortChecker'
tisto commented 9 years ago

https://travis-ci.org/plone/plone.recipe.codeanalysis/jobs/80188030

gforcada commented 9 years ago

@tisto will look at it at night, probably some copy & paste error (I basically copy&pasted flake8-plone-api code into this one, so some leftovers are around probably)

gforcada commented 9 years ago

I had to remove all caches to make travis run, that's weird...

Anyway is still failing because the default sorting on isort is the sections and not alphabetically, we need to add an .isort.cfg file.

gforcada commented 9 years ago

Unfortunately we are hitting https://github.com/timothycrosley/isort/pull/327

So we can either not enable it for p.r.codeanalysis and just document it (like the other flake8 plugins) or first fix the upstream problem.

I will try to work on the upstream problem on the weekend.

gforcada commented 9 years ago

Seems the issue is already fixed, we are missing a new release with it :-) I already asked it.

gforcada commented 9 years ago

We got a new release! Let's see what travis says :-)

gforcada commented 9 years ago

Tests pass, so given that #160 is already merged, we could make a new release with this, what do you think?

tisto commented 9 years ago

@gforcada will make a release later today...