search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 5 forks source link

Add xmllint and scss-lint #161

Closed janjaapdriessen closed 7 years ago

janjaapdriessen commented 9 years ago

What are the chances of this pull request being accepted? If so, I'll write some tests.

janjaapdriessen commented 9 years ago

I'm going to add Chameleon-xmllint too. We found added value in checking that our chameleon templates are valid XML, we would need to add a HTML wrapper in some cases, as seen in p01.checker:

http://pydoc.net/Python/p01.checker/0.5.2/p01.checker.checker/

gforcada commented 9 years ago

:+1: for merging it, some documentation about what are they purpose would be good. A paragraph for each of them on the README is probably enough, and, yes the tests :-)

janjaapdriessen commented 9 years ago

Thanks @gforcada for the quick reply. I'll polish docs and tests now I know there is a chance of landing these changes upstream.

tisto commented 9 years ago

Hey @janjaapdriessen, as @gforcada said, add tests and docs and we are happy to review and merge...

hvelarde commented 9 years ago

a squash would be appreciated also.

gforcada commented 9 years ago

@hvelarde let him finish first though...

jensens commented 8 years ago

this one fails in Python 3.4 and is therefore unmerged, or what else is missing?

jensens commented 7 years ago

Hence there was no activity for a long time, I propose the to close this PR within next two weeks. If you do not feel ok with this, please speak up and provide us a rough schedule.