search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 5 forks source link

Remove Isort from recommended #174

Closed do3cc closed 8 years ago

do3cc commented 8 years ago

at least until it does not work according to plone.api style guide See also #163

gforcada commented 8 years ago

What's wrong with adding a .isort.cfg? I was thinking of creating a pull request to warn about this within p.r.codeanalysis...

jensens commented 8 years ago

I think since flake8-isort 1.0 (see https://github.com/plone/plone.recipe.codeanalysis/issues/163#issuecomment-164943683) we have a solution to make everyone happy?

gforcada commented 8 years ago

@jensens thanks for adding some common sense, instead of removing things, let's make them suit all their needs...