search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 8 forks source link

<img tal:replace .... doesn't need an i18n:attributes #188

Closed agitator closed 8 years ago

agitator commented 8 years ago 
...some_template.pt:59:18:
-ERROR- - alt attribute of <img> lacks i18n:attributes
-------------------------------------------------------------------------------

the replace should be considered somehow

do3cc commented 8 years ago

Please more context. I just guess, but your image tag has a tal:replace? If so, is the replacement not an image tag? Does it have an alt tag? How shall the i18n:extractor know about this? Maybe you might actually want to add the tag after all?

gforcada commented 8 years ago

@agitator a newer version of i18ndude already fixed that, if you search on its issue tracker or CHANGES.rst you will find it.

agitator commented 8 years ago

the precommit hook was ranting about it and yes it was an image tag that got replaced

the issue i found https://github.com/collective/i18ndude/issues/4 is from 2013? the i18ndude within that buildout is 4.0.1

... will test again

gforcada commented 8 years ago

@agitator yes, thanks for digging it out, wow 2013! time flies...

agitator commented 8 years ago

4.0.1 solves that