plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 8 forks source link

remove flake8-commas from recommended due to bugs in the plugin #204

Closed jensens closed 6 years ago

jensens commented 7 years ago

see:

jensens commented 7 years ago

If merged also remove at https://github.com/plone/buildout.coredev/blob/5.1/experimental/qa.cfg#L26

gforcada commented 7 years ago

I'm personally against it, as breaking statements into more than one line rather than cramming everything and the kitchen sink into one line is far from readable.

Two highly recommended readings/watchings on the topic:

Now I notice that is the very same guy 😆

jensens commented 7 years ago

@gforcada ok to remove it unless the reported issues are fixed in the plugin? It does not help to get false errors reported.

gforcada commented 7 years ago

@jensens the plone.api issue was merged without needing to remove this plugin. Actually, thanks to @loechel we have a much more readable code now on plone.api.

He had to add a single noqa: C816, compared to the massive amounts of lines he cleaned up.

Although I don't like to litter the code base with noqa, it is far better to leave some here and there rather than removing the plugins (IMHO of course).

graingert commented 6 years ago

If you need to support versions of python lower than 3.6 you should ignore C816 globally @gforcada