search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 5 forks source link

Fix code analysis #206

Closed gforcada closed 7 years ago

gforcada commented 7 years ago

Regarding the print statements, should we move those to use logging?

One solution could be https://stackoverflow.com/questions/14058453

mauritsvanrees commented 7 years ago

Logging to stdout could help.

On the other hand: why are we against print statements? I think that is because it is not good in a web server environment: all output should go to a log file there, so printing is bad. For a code analysis script on the command line, printing is fine IMHO. So we might disable the printing check for this package.

gforcada commented 7 years ago

@mauritsvanrees yeah, that's true as well, I didn't want to have a special set of plugins for p.r.codeanalysis.

The canonical place for plugins anyway should be on bobtemplates.plone or buildout.coredev anyway...

I will remove that plugin at night, thanks for the review!