search

plone / plone.recipe.codeanalysis

provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks
https://pypi.org/project/plone.recipe.codeanalysis/
11 stars 8 forks source link

Run tests only once #208

Closed gforcada closed 7 years ago

gforcada commented 7 years ago

Running the coverage report already runs the tests.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.962% when pulling fcfd95ebe8dd8ee344b406216555afd931cc05dd on gforcada-run-tests-once into 9217ddf6eb730f459005961816f5190263e56be2 on master.

tisto commented 7 years ago

@gforcada the rationale behind this is that you don't want to run the expensive coverage if a test fails. There is always a tradeoff between fast failure and total execution time.

gforcada commented 7 years ago

Yes I know, but given that the package if small is a bit silly to run them twice just for the sake of it.

As it is on CI I consider that OK, locally you can still run tests without coverage.