search

plone / plone.recipe.zeoserver

zc.buildout recipe creating and configuring a ZODB zeo server
https://pypi.org/project/plone.recipe.zeoserver
3 stars 13 forks source link

Fix zeopack connection handling #3

Closed gaudenz closed 12 years ago

gaudenz commented 12 years ago

The previous fix to abort after a failed connection attempt only worked by chance and caused zeopack to exit before the packing finished. Now failed connections are correctly detected and zeopack waits until the packing is finished.

@mauritsvanrees could you please review and possibly merge this. Please check that the change of not waiting for the packing to be completed was really introduced accidentally. You introduced this "bug" in 130584246cadd7d7d9eaf04f20aea9ca6563f25f.

mauritsvanrees commented 12 years ago

With my original fix it goes fine as far as I can see. At least, I have not noticed problems in practice. But your changes make sense. I have merged it. Thanks!

gaudenz commented 12 years ago

Maurits van Rees notifications@github.com writes:

With my original fix it goes fine as far as I can see. At least, I have not noticed problems in practice.

It depends on your definition of going fine. It (by chance) fixes to problem if indefinitely hanging if the zeoserver is down. But it introduces a new problem that the script exits immediately and does not wait until packing is finished. This is annoying if you have a backup script which first packs and then does the (smaller) backup.

But your changes make sense. I have merged it.

Thanks for mergeing.

Gaudenz

Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. ~ Samuel Beckett ~