search

plone / plone.recipe.zeoserver

zc.buildout recipe creating and configuring a ZODB zeo server
https://pypi.org/project/plone.recipe.zeoserver
3 stars 13 forks source link

Removing ZODB3_HOME from runzeo.bat and zeoservice.py.in files #41

Closed fazalsulaiman closed 4 years ago

mister-roboto commented 4 years ago

@fazalsulaiman you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 4 years ago

@fazalsulaiman thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

fazalsulaiman commented 4 years ago

@jenkins-plone-org please run jobs

jensens commented 4 years ago

We should add Github actions and basic startup tests. Atm my time is limited, but I can answer questions.

mister-roboto commented 4 years ago

@fazalsulaiman you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

fazalsulaiman commented 4 years ago

I guess there was a big renaming from ZODB to ZODB3 a while ago, and these files got changed in the wrong way. Looks good to me, but I have not tried it. @jensens Do you have a chance to try this?

There is one failing test on Jenkins, but it is unrelated, so we can ignore that.

One minor thing: please don't edit the CHANGES.rst file directly. Read the comment at the top of that file on what to do instead. In this case, please create a file news/42.bugfix and put the changelog entry and your name in there.

If you can sign the Plone contributor agreement, like mentioned in one of the automated comments, that would help get this (and future PRs) merged. But as release manager, I can say that this is an obvious bugfix, and we can gratefully accept it without a signed agreement.

Thanks for the replay, removed CHANGES.rst changes and sent 'Plone Contributor Agreement', waiting for the replay from agreements@plone.org.

fazalsulaiman commented 4 years ago

For reopening the request for plone certificate verification

mister-roboto commented 4 years ago

@fazalsulaiman thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jensens commented 4 years ago

@fazalsulaiman next time please do not merge PRs yourself here. In github.com/plone we expect someone else to review and merge the code - after tests are all green. This usually does not take long. Opposed to this in github.com/zopefoundation we wait for an positive review and have all tests green - then the submitter should merge the pull request herself/himself.

fazalsulaiman commented 4 years ago

@fazalsulaiman next time please do not merge PRs yourself here. In github.com/plone we expect someone else to review and merge the code - after tests are all green. This usually does not take long. Opposed to this in github.com/zopefoundation we wait for an positive review and have all tests green - then the submitter should merge the pull request herself/himself.

Sure, I will do that