Add support for ``zmi-bookmarkable-urls`` and ``pid-filename``

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.

https://pypi.org/project/plone.recipe.zope2instance

6 stars 23 forks source link

Add support for ``zmi-bookmarkable-urls`` and ``pid-filename`` #113

Closed dataflake closed 5 years ago

dataflake commented 5 years ago

These keys have been added to Zope's own wsgischema.xml and if someone tries to use them with plone.recipe.zope2instance it will fail until this PR is merged and released.

Fixes #112.

mister-roboto commented 5 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 5 years ago

@jenkins-plone-org please run jobs

icemac commented 5 years ago

@mauritsvanrees Do you think the failures in Jenkins are related?

mauritsvanrees commented 5 years ago

Only fails on Plone 5.2 Python 2.7 with WebDav failures. I don't see a relation, but a relation is not always obvious. I have started another job. When that one is green, this PR can be merged.