search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Add Sentry support #124

Closed tschorr closed 5 years ago

tschorr commented 5 years ago

This PR adds basic Sentry support using the Python Sentry SDK as documented in https://docs.sentry.io/platforms/python/logging/.

mister-roboto commented 5 years ago

@tschorr thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

tschorr commented 5 years ago

@jenkins-plone-org please run jobs

zopyx commented 5 years ago

@tschorr I have an alternative implementation here:

https://github.com/collective/collective.sentry

How would you log the Zope specific request information as it is present in the standard error_log?

https://github.com/collective/collective.sentry/blob/master/collective/sentry/error_handler.py#L57-L74

tschorr commented 5 years ago

@zopyx thanks for the pointer, I didn't know about collective.sentry. As mentionned above, this PR is adding basic logging support, nothing Zope specific yet. I agree adding information from the Zope Request would be a plus. But I also think sentry configuration should go into the wsgi.ini, since this is the place were all the other logging is configured. And I like the idea of offering basic Sentry support with p.r.zope2instance.

zopyx commented 5 years ago

collective.sentry is less than a week old...I will check out PR.