search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

New zope options #135

Closed dataflake closed 4 years ago

dataflake commented 4 years ago

Fixes #134

This PR adds minimal support for two new Zope options. For now it is OK to just have them in the schema so that these options can be put into zope-conf-additional and sites running on plone.recipe.zope2instance don't completely fail when you try starting them with these options.

The fact that a separate copy of the schema is maintained here is a real PIA. I wonder if there's a better way, like plone.recipe.zope2instance using Zope's copy during startup instead.

mister-roboto commented 4 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 4 years ago

@jenkins-plone-org please run jobs

dataflake commented 4 years ago

The failing tests are coming out of plone.app.upgrade and have nothing to do with this package.

dataflake commented 4 years ago

@mauritsvanrees Thanks for the quick review. Would your or another maintainer mind cutting a release so this is ready for Zope 4.3? I am only waiting for https://github.com/zopefoundation/Zope/pull/787 and want to release 4.3 as soon as that's in there.

mauritsvanrees commented 4 years ago

I have released 6.6.0.

dataflake commented 4 years ago

Much appreciated!