search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Set the default for the http-fast-listen to on to match the documentation #143

Closed ale-rt closed 4 years ago

ale-rt commented 4 years ago

Refs. #71

mister-roboto commented 4 years ago

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

ale-rt commented 4 years ago

Thanks for the review :+1: I am going to implement the changes

ale-rt commented 4 years ago

@mauritsvanrees when you were refering to the wsgi_options you meant something like this, right? https://github.com/plone/plone.recipe.zope2instance/pull/143/commits/1d2a842ef177fa80ff7be72163bbd6ae72526166

mauritsvanrees commented 4 years ago

@ale-rt Yes, that is what I meant.

One test failure remaining on Travis, only on 2.7 apparently, which is a bit strange.

ale-rt commented 4 years ago

The Python 2.7 failure is related to ZServer, I am on it

ale-rt commented 4 years ago

Finally (when ZServer is not a thing anymore) the comment that suggests to set fast-listen to off appears also when fast-listen is not already set to off... :man_facepalming: 

# Set to off to defer opening of the HTTP socket until the end of the
# startup phase:
fast-listen on
ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

ale-rt commented 4 years ago

I rerun the jenkins test even if they are not actually testing this package. When they are complete I will merge this