Added option clear-untrusted-proxy-headers, with default false.

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.

https://pypi.org/project/plone.recipe.zope2instance

6 stars 23 forks source link

Added option clear-untrusted-proxy-headers, with default false. #154

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

See waitress documentation. Fixes a deprecation warning. Note that waitress 2 will change the default to true, but it looks like we would need to add other options then.

mister-roboto commented 4 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 4 years ago

No Jenkins tests needed: Jenkins does not run our tests, and does not even create a Plone instance during the buildout run.

jugmac00 commented 4 years ago

Thank you @mauritsvanrees for tackling this issue, and thank you @icemac for the review.