search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Add `max_request_body_size` option #156

Closed mpeeters closed 4 years ago

mpeeters commented 4 years ago

related to issue #155

mister-roboto commented 4 years ago

@mpeeters thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mpeeters commented 4 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 4 years ago

Actually, would you consider changing the option to max-request-body-size with dashes? That is what all other options use, except for a few sentry options. The resulting wsgi.ini file should still contain max_request_body_size of course.

mpeeters commented 4 years ago

@mauritsvanrees @icemac I will do the change for flake 8 and use dashes instead of underscores.

mauritsvanrees commented 4 years ago

Excellent, thanks. I will merge.