search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Allow both underscores and dashes in options #158

Open mauritsvanrees opened 4 years ago

mauritsvanrees commented 4 years ago

Most options have dashes, for example clear-untrusted-proxy-headers. But in the resulting wsgi.ini they need to be with underscores. The Sentry options have underscores.

That's a bit confusing. If you use the wrong spelling, buildout may warn that you have an unused parameter, but it won't fail, so you may not notice.

Would it be okay to accept both spellings? We could cleanup all options specified in the buildout config to dashes, or maybe duplicate them.

The only problem is that someone could accidentally use both option-foo and option_foo. If those two have a different value, we should quit with an error.

jensens commented 3 years ago

Agree, it either should fail or just magically work.