search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Restored ability to use own explicit version of zodb-temporary-storage. #160

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 3 years ago

You used to be able to set zodb-temporary-storage = <some config /> and have this config in the site.zcml. Most important use of this was to let this empty, effectively disabling the temporary storage. PR https://github.com/plone/plone.recipe.zope2instance/pull/93 changed this so you could do this in a more natural way, by setting zodb-temporary-storage = false.

But this (accidentally) removed the possibility for setting an explicit own version of the temporary storage snippet, and meant the only options now were false or true. The documentation still mentions:

If given, Zope's default temporary storage definition will be replaced by the lines of this parameter.

mister-roboto commented 3 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 3 years ago

Note: no Jenkins jobs needed, because Jenkins does not run our tests.

mauritsvanrees commented 3 years ago

LGTM.

Should there be a test?

That may be good, yes. I have added two tests now.