Fix `python-dotenv` dependency for Python 2 compatibility

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.

https://pypi.org/project/plone.recipe.zope2instance

7 stars 23 forks source link

Fix `python-dotenv` dependency for Python 2 compatibility #182

Closed dataflake closed 3 years ago

dataflake commented 3 years ago

Fixes #181

mister-roboto commented 3 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 3 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 3 years ago

Can't we restrict it only on Python 2, so people on Python 3 can use the latest if they want? Untested, but something like this:

'python-dotenv < 0.19; python_version<"3"',
'python-dotenv; python_version>="3"',

dataflake commented 3 years ago

@jenkins-plone-org please run jobs