search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

By default, do not create a tempstorage on Plone 6. #185

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

See https://github.com/plone/plone.recipe.zope2instance/issues/180, and lots more info in https://github.com/plone/Products.CMFPlone/issues/2957.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

I often forget: there is no need to run the Jenkins tests, because this recipe is not tested there.

mauritsvanrees commented 2 years ago

Can someone review this please? Note again: all GHA tests pass, but I did not start Jenkins tests because this package is not actually tested on Jenkins.

mauritsvanrees commented 2 years ago

I have merged it. Thanks for the review David!