plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Fix `python-dotenv` dependency for Python 3.10 compatibility. #186

Closed thet closed 2 years ago

mauritsvanrees commented 2 years ago

I have reverted this: it breaks Jenkins in Plone 5.2 and 6.0, because coredev pins an older version. See for example 6.0-3.8:

Version and requirements information containing python-dotenv:
  [versions] constraint on python-dotenv: 0.20.0
  Requirement of plone.recipe.zope2instance: python-dotenv>=0.21.0
While:
  Installing.
  Getting section instance.
  Initializing section instance.
  Installing recipe plone.recipe.zope2instance.
Error: The requirement ('python-dotenv>=0.21.0') is not allowed by your [versions] constraint (0.20.0)

I think we don't run Jenkins tests for PRs in this package because we don't run the plone.recipe.zope2instance tests in bin/test. But things can still break as you see. We may want to reconsider the testing strategy here. But that is for another time.

Meanwhile, @thet can you have another look please?

From a coredev standpoint, it is probably fine to update the version pin in versions.cfg. From the standpoint of the package and users outside of Plone (Zope users), just from looking at the title of the PR, I would have expected a change that only affects Python 3.10, not 3.7+.