plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Don't try to install eggs based on section name #187

Open perrinjerome opened 1 year ago

perrinjerome commented 1 year ago

zc.recipe.eggs.Egg by default install package with the same name as the section name. This is error prone in plone.recipe.zope2instance

see https://github.com/zopefoundation/Zope/pull/1080

mister-roboto commented 1 year ago

@perrinjerome you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 1 year ago

@perrinjerome you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

perrinjerome commented 1 year ago

I could not find a reason for inheriting the behavior of zc.recipe.egg here, but maybe I'm missing something.

@mauritsvanrees I have signed the contributor agreement this time 😉 and just sent it by email.

mauritsvanrees commented 1 year ago

I wonder if some people consider this a feature. Call the part Plone and it will install Plone.

perrinjerome commented 1 year ago

Yes, that's true. This behavior is not documented so I assumed it was a bug. We could also keep the behavior and change the documentation.

But my personal feeling is that it would be better to be explicit. https://github.com/zopefoundation/Zope/pull/1080 could have been more problematic if there was actually a "broken" package named zopeinstance on pypi