search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Fix #37 #41

Closed ida closed 6 years ago

ida commented 6 years ago

base-branch was wrongly set to master. now changed to 4.x

mauritsvanrees commented 6 years ago

O, for a next time, please give a PR a more descriptive title than 'fix #37'. I don't remember issue numbers from hundreds of packages. :-) But thanks for the fix!

ida commented 6 years ago

@mauritsvanrees oh yes, will give a more descriptive branch-name next time, thanks for reviewing! FWIW, now also noticed @ericof already created a branch which also includes test-configs, maybe that resolves mr.roboto's needs: https://github.com/plone/plone.recipe.zope2instance/commit/168ef68d8080365ccbfb68b253ed5c381fb198c0#diff-0c2e5b3920f1ae5a33c67bef82accd73

mauritsvanrees commented 6 years ago

Those extra Travis tests by Erico seem useful, but that can be done in a different PR.

Meanwhile Jenkins on 4.3 and 5.0 passes. 5.1 has a failure in plone.app.multilingual which should be unrelated; I think I have seen that before occasionally. I have restarted the 5.1 job.

ericof commented 6 years ago

I agree with @mauritsvanrees.

mauritsvanrees commented 6 years ago

I hunted down the cause of the Jenkins error on 5.1. I think Jenkins will be happy again after merge of https://github.com/plone/plone.app.multilingual/pull/313.

mauritsvanrees commented 6 years ago

I will merge. The Jenkins failures are unrelated and have meanwhile been fixed in plone.app.multilingual.

mauritsvanrees commented 6 years ago

Thanks, all!

ida commented 6 years ago

Jippieh, thanks gents and have a nice evening!

gotcha commented 6 years ago

@mauritsvanrees Should we cut a new release ?