search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Fix `bin/zinstance` script for `wsgi=on` #48

Closed icemac closed 6 years ago

icemac commented 6 years ago

Stripping of the first argument of argv is already done again in https://github.com/zopefoundation/Zope/blob/master/src/Zope2/Startup/serve.py#L136 which is called by Zope2.Startup.serve.main.

This extends the fix of #44, so I think no change log entry is needed.

tschorr commented 6 years ago

Lgtm. We'll need to change https://github.com/plone/buildout.coredev/blob/ad56ba4955ce4930cd9fc4abb9754c12463f4943/wsgi.cfg#L47 (remove --ini) once this is merged.

tschorr commented 6 years ago

This extends the fix of #44, so I think no change log entry is needed.

@icemac at least the testing changes are worth a changelog entry after all?

tschorr commented 6 years ago

Jenkins failure is unrelated (Jenkins was green without the Changelog modification).