search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

NameError: name 'ZServerCtlOptions' is not defined when running a script and ZServer is not available #56

Closed ale-rt closed 5 years ago

ale-rt commented 5 years ago

When ZServer is not available and the wsgi parameter is omitted the class ZServerCtlOptions is not defined and an error is raised.

See also: https://github.com/plone/plone.staticresources/issues/4

ale-rt commented 5 years ago

@davisagli @tschorr do you think it is better to automatically set the wsgi parameter to True when ZServer is not available or it is better to exit with an informative message?

davisagli commented 5 years ago

What I want to do is make it default to wsgi when ZServer is gone and ZServer when it is there. If wsgi is explicitly set as on or off in python 2, use that. If it’s explicitly set as off in python 3, raise an exception. The tests will need some adjustment.

David Glick (mobile)

On Nov 12, 2018, at 5:14 PM, Alessandro Pisa notifications@github.com wrote:

@davisagli @tschorr do you think it is better to automatically set the wsgi parameter to True when ZServer is not available or it is better to exit with an informative message?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ale-rt commented 5 years ago

I think this is already fixed in the meanwhile, at least my original issue is not reproducible anymore. Thanks!