plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Fix WSGI access log formatting configuration #89

Closed dataflake closed 5 years ago

dataflake commented 5 years ago

fixes #88

mister-roboto commented 5 years ago

Jens Vagelpohl your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

mister-roboto commented 5 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 5 years ago

I don't know why that contributor agreement test fails. Mine is from March 28, 2005 (!)

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

dataflake commented 5 years ago

@pbauer Philipp, who can I contact to make sure my contributor agreement is recorded correctly?

dataflake commented 5 years ago

@pbauer Figured it out, the email address on the agreement did not match the registered emails with GitHub anymore. I added the old one back in.

dataflake commented 5 years ago

@jenkins-plone-org please run jobs

dataflake commented 5 years ago

Check #91 for confirmation that the contributor agreement check passes now.

dataflake commented 5 years ago

@jenkins-plone-org please run jobs

dataflake commented 5 years ago

@jenkins-plone-org please run jobs